Skip to content

ci: Some reorganization #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
LecrisUT wants to merge 5 commits into
base: main
Choose a base branch
from
Open

ci: Some reorganization #58

LecrisUT wants to merge 5 commits into from

Conversation

@LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Apr 12, 2024 •
edited
Loading

Sorry, I just want to get some initial refactoring in order to have some more clean navigations of the project's actions. After the Qodana CI and build matrix, I will try help what I can and see what is broken

  • Separate the main CI/CD (ci.yml, release.yml) and components
  • Make main tests as a matrix based on IDE versions (Should add RC versions there as experimental in the future)
  • Separate build and test step? Not sure if this is possible, but would certainly be useful to share these accross test, test-ui, artifact-upload, etc. (Still not sure how to efficiently reuse the build artifacts, would need some info about the build/ folder structure)
  • Separate static-analysis step. Typically slow, requires a lot of permissions, and should run on only 1 version?
  • What to do with ReleaseDraft? Issue is this model is not as available to outside contributors, I think it would be better to just have the artifacts for users to try use
  • Unify release.yml. Typically I make it run on git tag and be dependent on all tests prior to that, what is your opinion on that? Deferred
  • Update GitHub actions
  • Remove/Update Qodana plugin

@LecrisUT LecrisUT force-pushed the ci/organize branch 3 times, most recently from a71c3ef to 30872a1 Compare April 12, 2024 08:46
@github-advanced-security
Copy link

github-advanced-security bot commented Apr 12, 2024

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@LecrisUT LecrisUT marked this pull request as draft April 12, 2024 09:37
@LecrisUT
Copy link
Collaborator Author

LecrisUT commented Apr 12, 2024 •
edited
Loading

Can you setup QODANA_TOKEN secret from https://qodana.cloud. Mostly so that there is a view for the qodana.cloud to check what inspections/linters can be enabled

@LecrisUT LecrisUT requested a review from YunaBraska April 12, 2024 15:51
@LecrisUT LecrisUT marked this pull request as ready for review April 12, 2024 15:51
@LecrisUT
Copy link
Collaborator Author

LecrisUT commented Apr 12, 2024 •
edited
Loading

I think it's ready for review, the only other part of getting the environment setup is:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YunaBraska YunaBraska Awaiting requested review from YunaBraska

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LecrisUT @YunaBraska